deniskuzZ commented on code in PR #12629: URL: https://github.com/apache/iceberg/pull/12629#discussion_r2014324613
########## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ########## @@ -321,107 +321,108 @@ public void testPartitionStats() throws Exception { ImmutableMap.of(TableProperties.DEFAULT_FILE_FORMAT, format.name())); List<Record> records = prepareRecords(testTable.schema()); - DataFile dataFile1 = - FileHelpers.writeDataFile( - testTable, outputFile(), TestHelpers.Row.of("foo", "A"), records.subList(0, 3)); - DataFile dataFile2 = - FileHelpers.writeDataFile( - testTable, outputFile(), TestHelpers.Row.of("foo", "B"), records.subList(3, 4)); - DataFile dataFile3 = - FileHelpers.writeDataFile( - testTable, outputFile(), TestHelpers.Row.of("bar", "A"), records.subList(4, 5)); - DataFile dataFile4 = - FileHelpers.writeDataFile( - testTable, outputFile(), TestHelpers.Row.of("bar", "B"), records.subList(5, 7)); + List<DataFile> dataFiles = dataFiles(testTable, records); + Snapshot snapshot1 = appendThriceAndValidate(testTable, dataFiles); + + commitDeletesAndValidate(testTable, dataFiles, snapshot1); + } + + private static Snapshot appendThriceAndValidate(Table testTable, List<DataFile> dataFiles) Review Comment: `appendMultipleAndValidate`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org