deniskuzZ commented on code in PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#discussion_r2014163324
##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -53,14 +56,43 @@ public static Collection<PartitionStats> computeStats(Table
table, Snapshot snap
StructType partitionType = Partitioning.partitionType(table);
List<ManifestFile> manifests = snapshot.allManifests(table.io());
- Queue<PartitionMap<PartitionStats>> statsByManifest =
Queues.newConcurrentLinkedQueue();
- Tasks.foreach(manifests)
- .stopOnFailure()
- .throwFailureWhenFinished()
- .executeWith(ThreadPools.getWorkerPool())
- .run(manifest -> statsByManifest.add(collectStats(table, manifest,
partitionType)));
+ return collectStats(table, manifests, partitionType).values();
+ }
+
+ /**
+ * Computes the partition stats incrementally after the given snapshot to
current snapshot.
+ *
+ * @param table the table for which partition stats to be computed.
+ * @param afterSnapshot the snapshot after which partition stats is computed
(exclusive).
+ * @param currentSnapshot the snapshot till which partition stats is
computed (inclusive).
+ * @return the {@link PartitionMap} of {@link PartitionStats}
+ */
+ public static PartitionMap<PartitionStats> computeStatsIncremental(
Review Comment:
few lines lower:
````
// GOOD: these uses of dropTable are clear to the reader
dropTable(identifier, true /* purge data */);
dropTable(identifier, purge);
````
https://github.com/apache/iceberg/blob/af99da6c2daa8e53876638c839b0f729f2f3a86e/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#L307
in my opinion it's the same situation:
````
computeStats(table, snapshot, recompute)
````
If you check `Catalog` interface further, you'll find one more similar API
design decision:
https://github.com/apache/iceberg/blob/af99da6c2daa8e53876638c839b0f729f2f3a86e/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#L208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
