rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2013049486
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -70,6 +77,22 @@ public static Type fromTypeName(String typeString) {
return TYPES.get(lowerTypeString);
}
+ Matcher geometry = GEOMETRY_PARAMETERS.matcher(typeString);
+ if (geometry.matches()) {
+ String crs = geometry.group(1);
+ Preconditions.checkArgument(!crs.contains(","), "Invalid CRS: %s", crs);
Review Comment:
Why is this invalid? This should pass the string as-is. It is up to others
to determine what is a valid CRS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
