adutra commented on code in PR #12566:
URL: https://github.com/apache/iceberg/pull/12566#discussion_r2011600401
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -250,25 +251,28 @@ public SdkHttpFullRequest sign(
} else {
Map<String, String> responseHeaders = Maps.newHashMap();
Consumer<Map<String, String>> responseHeadersConsumer =
responseHeaders::putAll;
- S3SignResponse s3SignResponse =
- httpClient()
- .withAuthSession(authSession())
- .post(
- endpoint(),
- remoteSigningRequest,
- S3SignResponse.class,
- Map.of(),
- ErrorHandlers.defaultErrorHandler(),
- responseHeadersConsumer);
-
- signedComponent =
- ImmutableSignedComponent.builder()
- .headers(s3SignResponse.headers())
- .signedURI(s3SignResponse.uri())
- .build();
-
- if (canBeCached(responseHeaders)) {
- SIGNED_COMPONENT_CACHE.put(cacheKey, signedComponent);
+ try (RESTClient restClient =
httpClient().withAuthSession(authSession())) {
Review Comment:
Yes, this is purely for correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
