nastra commented on code in PR #12566:
URL: https://github.com/apache/iceberg/pull/12566#discussion_r2001482330
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -324,7 +327,10 @@ public void close() throws IOException {
authSession.close();
}
} finally {
- httpClient.close(CloseMode.GRACEFUL);
+ if (root) {
+ // Only close the underlying Apache HTTP client if this is a root
HTTPClient.
+ httpClient.close(CloseMode.GRACEFUL);
Review Comment:
thanks for fixing this. I've noticed this during review and thought closing
the parent instance is implicitly prevented, but I guess I missed this
`finally` block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
