zeroshade commented on code in PR #351:
URL: https://github.com/apache/iceberg-go/pull/351#discussion_r2006135579
##########
table/table_test.go:
##########
@@ -280,10 +280,10 @@ func (t *TableWritingTestSuite) writeParquet(fio
iceio.WriteFileIO, filePath str
func (t *TableWritingTestSuite) createTable(identifier table.Identifier,
formatVersion int, spec iceberg.PartitionSpec, sc *iceberg.Schema) *table.Table
{
meta, err := table.NewMetadata(sc, &spec, table.UnsortedSortOrder,
- t.getMetadataLoc(), iceberg.Properties{"format-version":
strconv.Itoa(formatVersion)})
+ t.location, iceberg.Properties{"format-version":
strconv.Itoa(formatVersion)})
t.Require().NoError(err)
- return table.New(identifier, meta, t.location, iceio.LocalFS{}, nil)
+ return table.New(identifier, meta, t.getMetadataLoc(), iceio.LocalFS{},
nil)
Review Comment:
yea, i should probably rename that parameter.
that `location` parameter is *supposed* to be the metadata location. While
the tables base location should come from the Metadata that is passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
