zeroshade commented on code in PR #351:
URL: https://github.com/apache/iceberg-go/pull/351#discussion_r2006133656
##########
table/table_test.go:
##########
@@ -280,10 +280,10 @@ func (t *TableWritingTestSuite) writeParquet(fio
iceio.WriteFileIO, filePath str
func (t *TableWritingTestSuite) createTable(identifier table.Identifier,
formatVersion int, spec iceberg.PartitionSpec, sc *iceberg.Schema) *table.Table
{
meta, err := table.NewMetadata(sc, &spec, table.UnsortedSortOrder,
- t.getMetadataLoc(), iceberg.Properties{"format-version":
strconv.Itoa(formatVersion)})
+ t.location, iceberg.Properties{"format-version":
strconv.Itoa(formatVersion)})
Review Comment:
Yea, it's a little weird, but I get the handle on it now. the metadata only
knows the table's base location (`t.metadata.Location()`) while the table
itself knows the actual location of the metadata json file
(`t.metadataLocation`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
