Fokko commented on code in PR #330:
URL: https://github.com/apache/iceberg-go/pull/330#discussion_r1998933049
##########
table/table.go:
##########
@@ -72,6 +76,64 @@ func (t Table) LocationProvider() (LocationProvider, error) {
return LoadLocationProvider(t.metadataLocation, t.metadata.Properties())
}
+func (t Table) NewTransaction() *Transaction {
+ meta, _ := MetadataBuilderFromBase(t.metadata)
+
+ return &Transaction{
+ tbl: &t,
+ meta: meta,
+ reqs: []Requirement{},
Review Comment:
Why wouldn't you keep the updates and requirements next to each other in the
Transaction?
Later on, when we implement retries, the metadata might refresh if a table
has been updated. Then we can detect if we can re-apply the changes. Therefore
I think it is better to keep this at the Transaction level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
