Re: [PR] feat(table): Basic Transaction and AddFiles [iceberg-go]

[via GitHub]

Fokko commented on code in PR #330:
URL: https://github.com/apache/iceberg-go/pull/330#discussion_r1992184908


##########
table/arrow_utils_internal_test.go:
##########
@@ -408,3 +478,158 @@ func TestStatsTypes(t *testing.T) {
                iceberg.PrimitiveTypes.Int32,
        }, actual)
 }
+
+func constructTestTablePrimitiveTypes(t *testing.T) (*metadata.FileMetaData, 
Metadata) {
+       tableMeta, err := ParseMetadataString(`{
+        "format-version": 2,
+        "location": "s3://bucket/test/location",
+        "last-column-id": 7,
+        "current-schema-id": 0,
+        "schemas": [
+            {
+                "type": "struct",
+                "schema-id": 0,
+                "fields": [
+                    {"id": 1, "name": "booleans", "required": false, "type": 
"boolean"},
+                    {"id": 2, "name": "ints", "required": false, "type": 
"int"},
+                    {"id": 3, "name": "longs", "required": false, "type": 
"long"},
+                    {"id": 4, "name": "floats", "required": false, "type": 
"float"},
+                    {"id": 5, "name": "doubles", "required": false, "type": 
"double"},
+                    {"id": 6, "name": "dates", "required": false, "type": 
"date"},
+                    {"id": 7, "name": "times", "required": false, "type": 
"time"},
+                    {"id": 8, "name": "timestamps", "required": false, "type": 
"timestamp"},
+                    {"id": 9, "name": "timestamptzs", "required": false, 
"type": "timestamptz"},
+                    {"id": 10, "name": "strings", "required": false, "type": 
"string"},
+                    {"id": 11, "name": "uuids", "required": false, "type": 
"uuid"},
+                    {"id": 12, "name": "binaries", "required": false, "type": 
"binary"}
+                ]

Review Comment:
   For our sanity, should we also add 3 decimals? One with 8, 16 and 24 length 
covering the following cases:
   
   
![image](https://github.com/user-attachments/assets/51c3a4b9-8966-4ad4-bef0-a63b6bb3f5e4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org