gaborkaszab commented on code in PR #11837:
URL: https://github.com/apache/iceberg/pull/11837#discussion_r1993832511
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1621,6 +1627,82 @@ public void testRetainFilesOnRetainedBranches() {
assertThat(deletedFiles).isEqualTo(expectedDeletes);
}
+ @TestTemplate
+ public void testRemoveFromTableWithBulkIO() {
+ TestBulkLocalFileIO spyFileIO = Mockito.spy(new TestBulkLocalFileIO());
Review Comment:
Thanks for the suggestion, @pvary ! I tried this out, but apparently it's
not suitable for the tests to have a FileIO completely mocked, it would need at
least a TestFileIO instance to be able to make operations on the test tables.
In this case a very early step
(`tableWithBulkIO.newAppend().appendFile(FILE_A).commit();`) fails if there is
no FileIO instance just a mock under the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
