pvary commented on code in PR #11837:
URL: https://github.com/apache/iceberg/pull/11837#discussion_r1989419495
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1621,6 +1627,82 @@ public void testRetainFilesOnRetainedBranches() {
assertThat(deletedFiles).isEqualTo(expectedDeletes);
}
+ @TestTemplate
+ public void testRemoveFromTableWithBulkIO() {
+ TestBulkLocalFileIO spyFileIO = Mockito.spy(new TestBulkLocalFileIO());
Review Comment:
I don't get this approach.
If we create our own FileIO operation, why do we use Mockio to spy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
