nastra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1995609891
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1206,12 +1006,15 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
UpdateTableRequest.create(commit.identifier(),
commit.requirements(), commit.updates()));
}
- client.post(
- paths.commitTransaction(),
- new CommitTransactionRequest(tableChanges),
- null,
- headers(context),
- ErrorHandlers.tableCommitHandler());
+ AuthSession authSession = authManager.contextualSession(context,
catalogAuth);
Review Comment:
this is just a nit, but it would be good to generally align with how the
session is named across this entire class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
