nastra commented on code in PR #12197: URL: https://github.com/apache/iceberg/pull/12197#discussion_r1995619212
########## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ########## @@ -81,13 +77,14 @@ public abstract class S3V4RestSignerClient private static final String SCOPE = "sign"; @SuppressWarnings("immutables:incompat") - private static volatile ScheduledExecutorService tokenRefreshExecutor; + private volatile AuthManager authManager; Review Comment: related to my other comment from https://github.com/apache/iceberg/pull/12197/files#r1993040250 I currently don't know whether having this field being non-static would cause what was earlier tested in https://github.com/apache/iceberg/pull/12197/files#r1993040250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org