zeroshade commented on code in PR #326:
URL: https://github.com/apache/iceberg-go/pull/326#discussion_r1995759395
##########
catalog/glue/glue_test.go:
##########
@@ -778,12 +781,103 @@ func TestGlueListNamespacesIntegration(t *testing.T) {
}
assert := require.New(t)
- awscfg, err := config.LoadDefaultConfig(context.TODO(),
config.WithClientLogMode(aws.LogRequest|aws.LogResponse))
+ awsCfg, err := config.LoadDefaultConfig(context.TODO(),
config.WithClientLogMode(aws.LogRequest|aws.LogResponse))
assert.NoError(err)
- catalog := NewCatalog(WithAwsConfig(awscfg))
+ ctlg := NewCatalog(WithAwsConfig(awsCfg))
- namespaces, err := catalog.ListNamespaces(context.TODO(), nil)
+ namespaces, err := ctlg.ListNamespaces(context.TODO(), nil)
assert.NoError(err)
assert.Contains(namespaces, []string{os.Getenv("TEST_DATABASE_NAME")})
}
+
+func TestGlueCreateTableSuccessIntegration(t *testing.T) {
+ if os.Getenv("TEST_DATABASE_NAME") == "" {
+ t.Skip()
+ }
+ if os.Getenv("TEST_TABLE_NAME") == "" {
+ t.Skip()
+ }
+ if os.Getenv("TEST_TABLE_LOCATION") == "" {
+ t.Skip()
+ }
Review Comment:
Yea, that makes a lot of sense. I'd say we can skip over it until we address
the comment in the TODO unless the happy path can be consistently tested
without flakiness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
