zeroshade commented on code in PR #326:
URL: https://github.com/apache/iceberg-go/pull/326#discussion_r1987873141
##########
catalog/glue/glue_test.go:
##########
@@ -778,12 +781,103 @@ func TestGlueListNamespacesIntegration(t *testing.T) {
}
assert := require.New(t)
- awscfg, err := config.LoadDefaultConfig(context.TODO(),
config.WithClientLogMode(aws.LogRequest|aws.LogResponse))
+ awsCfg, err := config.LoadDefaultConfig(context.TODO(),
config.WithClientLogMode(aws.LogRequest|aws.LogResponse))
assert.NoError(err)
- catalog := NewCatalog(WithAwsConfig(awscfg))
+ ctlg := NewCatalog(WithAwsConfig(awsCfg))
- namespaces, err := catalog.ListNamespaces(context.TODO(), nil)
+ namespaces, err := ctlg.ListNamespaces(context.TODO(), nil)
assert.NoError(err)
assert.Contains(namespaces, []string{os.Getenv("TEST_DATABASE_NAME")})
}
+
+func TestGlueCreateTableSuccessIntegration(t *testing.T) {
+ if os.Getenv("TEST_DATABASE_NAME") == "" {
+ t.Skip()
+ }
+ if os.Getenv("TEST_TABLE_NAME") == "" {
+ t.Skip()
+ }
+ if os.Getenv("TEST_TABLE_LOCATION") == "" {
+ t.Skip()
+ }
Review Comment:
I'd have to look deeper at how glue works in order to figure out the
difference, I'll get back to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
