szehon-ho commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1996622869
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -141,11 +145,39 @@ static void toJson(Types.MapType map, JsonGenerator
generator) throws IOExceptio
}
static void toJson(Type.PrimitiveType primitive, JsonGenerator generator)
throws IOException {
- generator.writeString(primitive.toString());
+ switch (primitive.typeId()) {
Review Comment:
Im ok with that, initially I thought its a bit complex as the crs can be
projjson content. But now it is a table property, so should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
