rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1996302892


##########
api/src/test/java/org/apache/iceberg/types/TestTypes.java:
##########
@@ -81,6 +81,56 @@ public void fromPrimitiveString() {
         .withMessage("Cannot parse type string to primitive: abcdefghij");
   }
 
+  @Test
+  public void geospatialTypeFromTypeName() {
+    
assertThat(Types.fromPrimitiveString("geometry")).isEqualTo(Types.GeometryType.crs84());
+    
assertThat(Types.fromPrimitiveString("geometry()")).isEqualTo(Types.GeometryType.crs84());

Review Comment:
   Why is this a valid? It seems like a problem to me. We don't allow `long()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to