RussellSpitzer commented on code in PR #12528:
URL: https://github.com/apache/iceberg/pull/12528#discussion_r1996373199
##########
api/src/main/java/org/apache/iceberg/types/Comparators.java:
##########
@@ -108,6 +109,15 @@ public int compare(StructLike o1, StructLike o2) {
return 0;
}
+ if (o1 instanceof StructProjection && o2 instanceof StructProjection) {
Review Comment:
I think that's true, but that we should fix it in the partition list
evaluation and not in the base equality method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
