RussellSpitzer commented on code in PR #12528:
URL: https://github.com/apache/iceberg/pull/12528#discussion_r1996345959
##########
api/src/main/java/org/apache/iceberg/types/Comparators.java:
##########
@@ -108,6 +109,15 @@ public int compare(StructLike o1, StructLike o2) {
return 0;
}
+ if (o1 instanceof StructProjection && o2 instanceof StructProjection) {
Review Comment:
I think this is going to break other things, because most other places in
the code we do want those partitions to be equal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
