bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1995860043
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##########
@@ -125,4 +161,35 @@ private void processControlEvents() {
worker.process();
}
}
+
+ private void startWorker() {
+ if (null == this.worker) {
+ LOG.info("Starting commit worker");
+ SinkWriter sinkWriter = new SinkWriter(catalog, config);
+ worker = new Worker(config, clientFactory, sinkWriter, context);
+ worker.start();
+ }
+ }
+
+ private void startCoordinator() {
+ LOG.info("Task elected leader, starting commit coordinator");
Review Comment:
We should protect against multiple coordinator threads here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
