bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1995826283
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##########
@@ -43,6 +43,21 @@ public class CommitterImpl implements Committer {
private CoordinatorThread coordinatorThread;
private Worker worker;
+ private Catalog icebergCatalog;
+ private IcebergSinkConfig icebergSinkConfig;
+ private SinkTaskContext sinkTaskContext;
+ private KafkaClientFactory clientFactory;
+ private Collection<MemberDescription> membersWhenWorkerIsCoordinator;
+ private final AtomicBoolean isInitialized = new AtomicBoolean(false);
+
+ private void initialize(Catalog catalog, IcebergSinkConfig config,
SinkTaskContext context) {
+ if (isInitialized.compareAndSet(false, true)) {
+ this.icebergCatalog = catalog;
+ this.icebergSinkConfig = config;
+ this.sinkTaskContext = context;
Review Comment:
We should revert the variable names to what they were.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
