SanjayMarreddi commented on code in PR #12503:
URL: https://github.com/apache/iceberg/pull/12503#discussion_r1992150004
##########
aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java:
##########
@@ -63,8 +63,15 @@ public S3Client s3() {
@Override
public S3AsyncClient s3Async() {
if (s3FileIOProperties.isS3CRTEnabled()) {
- return S3AsyncClient.crtBuilder().build();
+ return S3AsyncClient.crtBuilder()
+ .applyMutation(awsClientProperties::applyClientRegionConfiguration)
+
.applyMutation(awsClientProperties::applyClientCredentialConfigurations)
+ .applyMutation(s3FileIOProperties::applyS3CrtConfigurations)
+ .build();
}
- return S3AsyncClient.builder().build();
+ return S3AsyncClient.builder()
+ .applyMutation(awsClientProperties::applyClientRegionConfiguration)
Review Comment:
Agree, I have added the support for the `endpointConfigurations`. Currently
CRTAsyncClient does not have support to pass serviceConfiguration similar to
other async clients, so I think we could possibly pause on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
