wypoon commented on code in PR #12449:
URL: https://github.com/apache/iceberg/pull/12449#discussion_r1990442821
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -204,6 +204,10 @@ public Schema(int schemaId, NestedField... columns) {
this(schemaId, Arrays.asList(columns));
}
+ public Schema(Map<String, Integer> aliases, NestedField... columns) {
+ this(Arrays.asList(columns), aliases);
+ }
Review Comment:
I'd be hesitant to add to the API. This is only used for a test; can't you
use an existing constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
