sririshindra commented on PR #12449: URL: https://github.com/apache/iceberg/pull/12449#issuecomment-2744700338
> @sririshindra thanks for this PR. Do you think it is worth adding tests where the column is a long/timestamp and where the column is a string (binary column)? Thanks @wypoon I added a test for long and string as well. That actually turned out to be very useful as that caught a bug that I didn't know previously. There was an unnecessary cast of the litset to HashSet in the previous version. I now removed it and the Tests that I added all succeed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
