swapna267 commented on code in PR #12191:
URL: https://github.com/apache/iceberg/pull/12191#discussion_r1990246723
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -175,6 +178,18 @@ public Result applyFilters(List<ResolvedExpression>
flinkFilters) {
return Result.of(acceptedFilters, flinkFilters);
}
+ @Override
+ public void applySourceWatermark() {
+ if
(!readableConfig.get(FlinkConfigOptions.TABLE_EXEC_ICEBERG_USE_FLIP27_SOURCE)) {
Review Comment:
Thought it would be better to throw UnsupportedOperation Exception instead
of IllegalArgument or IllegalStateException. If either of them is fine with
current error message , I can move to Preconditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
