ZENOTME commented on code in PR #999: URL: https://github.com/apache/iceberg-rust/pull/999#discussion_r1987508957
########## crates/iceberg/src/lib.rs: ########## @@ -50,6 +50,87 @@ //! Ok(()) //! } //! ``` +//! +//! ## Fast append data to table +//! +//! ```rust, no_run Review Comment: > You mean the whole example? I'm not a big fan of that way. For writer doc, it should only focus on how to use a writer. The whole story of using different picecs in a compute engine is an advanced topic, and deserves a single chapter for that. It involves not only code, but also explaination the design in it. Sounds reasonable for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
