liurenjie1024 commented on code in PR #999: URL: https://github.com/apache/iceberg-rust/pull/999#discussion_r1968783422
########## crates/iceberg/src/lib.rs: ########## @@ -50,6 +50,87 @@ //! Ok(()) //! } //! ``` +//! +//! ## Fast append data to table +//! +//! ```rust, no_run Review Comment: Hi, @ZENOTME Thanks for this, but I don't think this is a good example of writing data since it involves too many low level api invocation. We should have a high level api to accept a stream of arrow record batches, and have the transaction, file writer hidden under the hood, just like what we did in table scan to convert table to an arrow batch stream. Or we could integrate with datafusion do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
