Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1984738489
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +561,120 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return of("");
+ }
+
+ public static GeometryType of(String crs) {
+ return new GeometryType(crs == null ? "" : crs);
+ }
+
+ @Override
+ public TypeID typeId() {
+ return TypeID.GEOMETRY;
+ }
+
+ public String crs() {
Review Comment:
The `NotNull` annotation requires an additional dependency, and I noticed
that it is not currently used in iceberg-api or iceberg-core. Would you like me
to add the additional dependency and annotate this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
