Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1982624089
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +561,120 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return of("");
+ }
+
+ public static GeometryType of(String crs) {
+ return new GeometryType(crs == null ? "" : crs);
Review Comment:
I believed that including crs.isEmpty() was redundant in this situation, so
I didn't add it, as we would return an empty string regardless.
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +561,120 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return of("");
+ }
+
+ public static GeometryType of(String crs) {
+ return new GeometryType(crs == null ? "" : crs);
Review Comment:
I believed that including `crs.isEmpty()` was redundant in this situation,
so I didn't add it, as we would return an empty string regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
