swapna267 commented on code in PR #12199:
URL: https://github.com/apache/iceberg/pull/12199#discussion_r1978409403
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -404,10 +437,15 @@ void createIcebergTable(ObjectPath tablePath,
ResolvedCatalogTable table, boolea
ImmutableMap.Builder<String, String> properties = ImmutableMap.builder();
String location = null;
for (Map.Entry<String, String> entry : table.getOptions().entrySet()) {
- if ("location".equalsIgnoreCase(entry.getKey())) {
- location = entry.getValue();
- } else {
+ if (!isReservedProperty(entry.getKey())) {
properties.put(entry.getKey(), entry.getValue());
+ } else {
+ // Filtering reserved properties like catalog properties(added to
support CREATE TABLE LIKE
+ // in getTable()),
+ // location and not persisting on table properties.
+ if ("location".equalsIgnoreCase(entry.getKey())) {
Review Comment:
location is being used at too many places across iceberg code. Not sure what
would be right place and do we want to change across all usages ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
