stevenzwu commented on code in PR #12199:
URL: https://github.com/apache/iceberg/pull/12199#discussion_r1980372419
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -332,7 +335,33 @@ public List<String> listTables(String databaseName)
public CatalogTable getTable(ObjectPath tablePath)
throws TableNotExistException, CatalogException {
Table table = loadIcebergTable(tablePath);
- return toCatalogTable(table);
+
+ // Flink's CREATE TABLE LIKE clause relies on properties sent back here to
create new table.
+ // Inorder to create such table in non iceberg catalog, we need to send
across catalog
+ // properties also.
+ // As Flink API accepts only Map<String, String> for props, here we are
serializing catalog
+ // props as json string to distinguish between catalog and table
properties in createTable.
+ String srcCatalogProps =
+ FlinkCreateTableOptions.toJson(
+ getName(), tablePath.getDatabaseName(), tablePath.getObjectName(),
catalogProps);
+
+ Map<String, String> tableProps = table.properties();
+ if (tableProps.containsKey(FlinkCreateTableOptions.CONNECTOR_PROPS_KEY)
+ ||
tableProps.containsKey(FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY)) {
+ throw new IllegalArgumentException(
+ String.format(
+ "Source table %s contains one/all of the reserved property keys:
%s, %s." + tablePath,
Review Comment:
there is a syntax error here, `+ tablePath` should be `, tablePath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
