lliangyu-lin commented on code in PR #12401:
URL: https://github.com/apache/iceberg/pull/12401#discussion_r1974114780
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -494,22 +499,22 @@ public ViewMetadata build() {
@VisibleForTesting
static List<ViewVersion> expireVersions(
- Map<Integer, ViewVersion> versionsById, int numVersionsToKeep,
ViewVersion currentVersion) {
+ Map<Integer, ViewVersion> versionsById,
+ int numVersionsToKeep,
+ Set<ViewVersion> keepVersions) {
Review Comment:
Thanks @nastra for the review.
Yeah, the ```addVersionInternal``` will only add new versions with highest
id + 1.
In that case, it make sense just make sure the ```numVersionsToKeep``` has
the correct value and pass to expireVersions and no need to update to API. Let
me update this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
