nastra commented on code in PR #12401:
URL: https://github.com/apache/iceberg/pull/12401#discussion_r1973800528
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -494,22 +499,22 @@ public ViewMetadata build() {
@VisibleForTesting
static List<ViewVersion> expireVersions(
- Map<Integer, ViewVersion> versionsById, int numVersionsToKeep,
ViewVersion currentVersion) {
+ Map<Integer, ViewVersion> versionsById,
+ int numVersionsToKeep,
+ Set<ViewVersion> keepVersions) {
Review Comment:
rather than changing this API I think we can also just do this:
```
--- a/core/src/main/java/org/apache/iceberg/view/ViewMetadata.java
+++ b/core/src/main/java/org/apache/iceberg/view/ViewMetadata.java
@@ -35,6 +35,7 @@ import org.apache.iceberg.exceptions.ValidationException;
import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
@@ -463,8 +464,13 @@ public interface ViewMetadata extends Serializable {
historySize);
// expire old versions, but keep at least the versions added in this
builder
- int numAddedVersions = (int)
changes(MetadataUpdate.AddViewVersion.class).count();
- int numVersionsToKeep = Math.max(numAddedVersions, historySize);
+ Set<Integer> addedVersions =
+ changes(MetadataUpdate.AddViewVersion.class)
+ .map(v -> v.viewVersion().versionId())
+ .collect(Collectors.toSet());
+ int numVersions =
+
ImmutableSet.builder().addAll(addedVersions).add(currentVersionId).build().size();
+ int numVersionsToKeep = Math.max(numVersions, historySize);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
