danielcweeks commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r1966087640
##########
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##########
@@ -786,4 +831,51 @@ public <D> AvroIterable<D> build() {
public static long rowCount(InputFile file) {
return AvroIO.findStartingRowPos(file::newStream, Long.MAX_VALUE);
}
+
+ public static class ReaderService implements
DataFileServiceRegistry.ReaderService {
+ @Override
+ public DataFileServiceRegistry.Key key() {
+ return new DataFileServiceRegistry.Key(FileFormat.AVRO,
Record.class.getName());
Review Comment:
I don't like the idea of introducing SPI to register formats like this. It
was discussed when introducing parquet via InternalData and we want to explicit
about the formats we officially support in order to avoid bifurcation and
incompatibility of data.
We also don't use SPI anywhere else in the core projects, which is why we
used Dyn classes with InternalData.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
