pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r1965239684
########## core/src/main/java/org/apache/iceberg/io/datafile/ReaderBuilder.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io.datafile; + +import java.nio.ByteBuffer; +import org.apache.iceberg.InternalData; +import org.apache.iceberg.Schema; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.mapping.NameMapping; + +/** Builder API for reading Iceberg data files. */ +public interface ReaderBuilder extends InternalData.ReadBuilder { + /** + * Restricts the read to the given range: [start, start + length). + * + * @param newStart the start position for this read + * @param newLength the length of the range this read should scan + */ + @Override + ReaderBuilder split(long newStart, long newLength); + + /** Read only the given columns. */ + @Override + ReaderBuilder project(Schema newSchema); + + /** Sets the reader to case-sensitive when matching column names. */ + default ReaderBuilder caseInsensitive() { + return caseSensitive(false); + } + + default ReaderBuilder caseSensitive(boolean newCaseSensitive) { + // Just ignore case sensitivity if not available + return this; + } + + /** Enables record filtering. */ + default ReaderBuilder filterRecords(boolean newFilterRecords) { + // Skip filtering if not available + return this; + } + + /** + * Pushes down the {@link Expression} filter for the reader to prevent reading unnecessary + * records. + */ + default ReaderBuilder filter(Expression newFilter) { + // Skip filtering if not available + return this; + } + + /** Sets configuration key/value pairs for the reader. */ + default ReaderBuilder set(String key, String value) { + throw new UnsupportedOperationException("Not supported"); + } + + /** Enables reusing the containers returned by the reader. Decreases pressure on GC. */ + @Override + default ReaderBuilder reuseContainers() { Review Comment: It is also used by Avro. See: https://github.com/apache/iceberg/blob/604422b056efee145f69944c39b4d99787dfd9f1/core/src/main/java/org/apache/iceberg/avro/AvroIterable.java#L51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
