pvary commented on code in PR #12306: URL: https://github.com/apache/iceberg/pull/12306#discussion_r1961247530
########## core/src/main/java/org/apache/iceberg/actions/FileRewriteExecutor.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.ContentScanTask; + +/** + * A class for rewriting content file groups ({@link FileRewriteGroup}). The lifecycle for the + * executor looks like the following: + * + * <ul> + * <li>{@link #init(Map)} initializes the executor with the configuration parameters + * <li>{@link #rewrite(FileRewriteGroup)} called for every group in the plan to do the actual + * rewrite of the files, and returns the generated new files. + * </ul> + * + * A single executor could be used to rewrite multiple groups for the same plan. + * + * @param <FGI> the Java type of the plan info like {@link RewriteDataFiles.FileGroupInfo} or {@link + * RewritePositionDeleteFiles.FileGroupInfo} + * @param <T> the Java type of the tasks to read the files which are rewritten + * @param <F> the Java type of the content files which are rewritten + * @param <G> the Java type of the planned groups + */ +public interface FileRewriteExecutor< + FGI, Review Comment: I didn't change this, because the info objects are coming from the immutable base infrastructure for the actions. I decided against touching those to limit the scope of the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
