pvary commented on code in PR #12306: URL: https://github.com/apache/iceberg/pull/12306#discussion_r1961237242
########## core/src/main/java/org/apache/iceberg/actions/FileRewriteGroup.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import java.util.List; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.ContentScanTask; + +/** + * Container class representing a set of files to be rewritten by a {@link FileRewriteExecutor}. + * + * @param <I> the Java type of the plan info member like {@link RewriteDataFiles.FileGroupInfo} or + * {@link RewritePositionDeleteFiles.FileGroupInfo} + * @param <T> the Java type of the tasks to read the files which are rewritten + * @param <F> the Java type of the content files which are rewritten + */ +public abstract class FileRewriteGroup<I, T extends ContentScanTask<F>, F extends ContentFile<F>> { Review Comment: Names staring with `Base` are reserved for the immutable interfaces for the actions themselves. I would like to keep the FileRewriteGroup/FileRewritePlan/FileRewritePlanner/FileRewriteRunner similar and/or grouped together. Maybe create a new package (org.apache.iceberg.actions.rewrite)? Maybe a name starting with the same prefix (RewriteGroup/RewritePlan/RewritePlanner/RewriteRunner)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
