kevinjqliu commented on PR #12291: URL: https://github.com/apache/iceberg/pull/12291#issuecomment-2666393082
Would be helpful to add the specific code path for `snapshot_ids` in `expired_snapshots` For example, https://github.com/apache/iceberg/blob/0b47faaada2aafa42c118be78445f6c40fc0ead6/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java#L140-L144 https://github.com/apache/iceberg/blob/0b47faaada2aafa42c118be78445f6c40fc0ead6/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java#L149-L151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
