estherbester commented on code in PR #12291: URL: https://github.com/apache/iceberg/pull/12291#discussion_r1958662642
########## docs/docs/spark-procedures.md: ########## @@ -270,7 +270,8 @@ the `expire_snapshots` procedure will never remove files which are still require | `retain_last` | | int | Number of ancestor snapshots to preserve regardless of `older_than` (defaults to 1) | | `max_concurrent_deletes` | | int | Size of the thread pool used for delete file actions (by default, no thread pool is used) | | `stream_results` | | boolean | When true, deletion files will be sent to Spark driver by RDD partition (by default, all the files will be sent to Spark driver). This option is recommended to set to `true` to prevent Spark driver OOM from large file size | -| `snapshot_ids` | | array of long | Array of snapshot IDs to expire. | +| `snapshot_ids` | | array of long | Array of snapshot IDs to expire (note that the table's expiration properties will still be applied to remove all expired snapshots, unless `older_than` or `retain_last` arguments are also given). | Review Comment: Thanks for the quick feedback! Reworded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
