XBaith commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1955818227
########## core/src/main/java/org/apache/iceberg/variants/VariantBuilderBase.java: ########## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.variants; + +import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.nio.charset.StandardCharsets; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +abstract class VariantBuilderBase { + private static final int MAX_DECIMAL4_PRECISION = 9; + private static final int MAX_DECIMAL8_PRECISION = 18; + protected static final int MAX_DECIMAL16_PRECISION = 38; + + private final ByteBufferWrapper valueBuffer; + private final Dictionary dict; + private int startPos; + + ByteBufferWrapper valueBuffer() { + return valueBuffer; + } + + Dictionary dict() { + return dict; + } + + int startPos() { + return startPos; + } + + VariantBuilderBase(ByteBufferWrapper valueBuffer, Dictionary dict) { + this.valueBuffer = valueBuffer; + this.dict = dict; + startPos = valueBuffer.pos; + } + + /** + * Builds the variant metadata from `dictionaryKeys` and returns the resulting Variant object. + * + * @return The constructed Variant object. + */ + public Variant build() { + int numKeys = dict.size(); + + // Calculate total size of dictionary strings + long numStringBytes = dict.totalBytes(); + + // Determine the number of bytes required for dictionary size and offset entry + int offsetSize = sizeOf(Math.max((int) numStringBytes, numKeys)); + + // metadata: header byte, dictionary size, offsets and string bytes + long metadataSize = 1 + offsetSize + (numKeys + 1) * offsetSize + numStringBytes; + + ByteBuffer metadataBuffer = + ByteBuffer.allocate((int) metadataSize).order(ByteOrder.LITTLE_ENDIAN); + + // Write header byte (version + offset size) + VariantUtil.writeByte( + metadataBuffer, VariantUtil.metadataHeader(Variants.VERSION, offsetSize), 0); + + // Write number of keys + VariantUtil.writeLittleEndianUnsigned(metadataBuffer, numKeys, 1, offsetSize); + + // Write offsets + int offset = 1 + offsetSize; + int dictOffset = 0; + for (byte[] key : dict.keys()) { + VariantUtil.writeLittleEndianUnsigned(metadataBuffer, dictOffset, offset, offsetSize); + dictOffset += key.length; + offset += offsetSize; + } + VariantUtil.writeLittleEndianUnsigned(metadataBuffer, numStringBytes, offset, offsetSize); + + // Write dictionary strings + offset += offsetSize; + for (byte[] key : dict.keys()) { + VariantUtil.writeBufferAbsolute(metadataBuffer, offset, ByteBuffer.wrap(key)); + offset += key.length; + } + + return new VariantImpl(metadataBuffer, valueBuffer.buffer); + } + + protected void writeNullInternal() { + valueBuffer.writePrimitive(Variants.PhysicalType.NULL, null); Review Comment: ```suggestion valueBuffer.writePrimitive(PhysicalType.NULL, null); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
