RussellSpitzer commented on code in PR #12255:
URL: https://github.com/apache/iceberg/pull/12255#discussion_r1954956756
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -1075,49 +1075,49 @@ private void checkResult(
List<DeleteFile> rewrittenDeletes,
List<DeleteFile> newDeletes,
int expectedGroups) {
- assertThat(rewrittenDeletes.size())
+ assertThat(result.rewrittenDeleteFilesCount())
.as("Rewritten delete file count")
- .isEqualTo(result.rewrittenDeleteFilesCount());
+ .isEqualTo(rewrittenDeletes.size());
- assertThat(newDeletes.size())
+ assertThat(result.addedDeleteFilesCount())
.as("New delete file count")
- .isEqualTo(result.addedDeleteFilesCount());
+ .isEqualTo(newDeletes.size());
- assertThat(size(rewrittenDeletes))
+ assertThat(result.rewrittenBytesCount())
.as("Rewritten delete byte count")
- .isEqualTo(result.rewrittenBytesCount());
+ .isEqualTo(size(rewrittenDeletes));
- assertThat(size(newDeletes)).as("New delete byte
count").isEqualTo(result.addedBytesCount());
+ assertThat(result.addedBytesCount()).as("New delete byte
count").isEqualTo(size(newDeletes));
- assertThat(expectedGroups).as("Rewrite group
count").isEqualTo(result.rewriteResults().size());
+ assertThat(result.rewriteResults()).as("Rewrite group
count").hasSize(expectedGroups);
- assertThat(rewrittenDeletes.size())
- .as("Rewritten delete file count in all groups")
- .isEqualTo(
+ assertThat(
result.rewriteResults().stream()
.mapToInt(FileGroupRewriteResult::rewrittenDeleteFilesCount)
- .sum());
+ .sum())
+ .as("Rewritten delete file count in all groups")
+ .isEqualTo(rewrittenDeletes.size());
- assertThat(newDeletes.size())
- .as("Added delete file count in all groups")
- .isEqualTo(
+ assertThat(
result.rewriteResults().stream()
.mapToInt(FileGroupRewriteResult::addedDeleteFilesCount)
- .sum());
+ .sum())
+ .as("Added delete file count in all groups")
+ .isEqualTo(newDeletes.size());
- assertThat(size(rewrittenDeletes))
- .as("Rewritten delete bytes in all groups")
- .isEqualTo(
+ assertThat(
result.rewriteResults().stream()
.mapToLong(FileGroupRewriteResult::rewrittenBytesCount)
- .sum());
+ .sum())
+ .as("Rewritten delete bytes in all groups")
+ .isEqualTo(size(rewrittenDeletes));
Review Comment:
`size` sums Size in bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
