nastra commented on code in PR #12255:
URL: https://github.com/apache/iceberg/pull/12255#discussion_r1954587640
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -1075,49 +1075,49 @@ private void checkResult(
List<DeleteFile> rewrittenDeletes,
List<DeleteFile> newDeletes,
int expectedGroups) {
- assertThat(rewrittenDeletes.size())
+ assertThat(result.rewrittenDeleteFilesCount())
Review Comment:
the `result` contains the results after rewriting position deletes and is
the `actual` part of the comparison. `rewrittenDeletes` contains the `expected`
information. The same applies for all the other changes below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
