dttung2905 commented on code in PR #290:
URL: https://github.com/apache/iceberg-go/pull/290#discussion_r1953172834
##########
catalog/rest/rest.go:
##########
@@ -989,3 +989,54 @@ func (r *Catalog) CheckTableExists(ctx context.Context,
identifier table.Identif
}
return true, nil
}
+
+func (r *Catalog) ListViews(ctx context.Context, namespace table.Identifier)
([]table.Identifier, error) {
+ if err := checkValidNamespace(namespace); err != nil {
+ return nil, err
+ }
+
+ ns := strings.Join(namespace, namespaceSeparator)
+ path := []string{"namespaces", ns, "views"}
+
+ type resp struct {
+ Identifiers []identifier `json:"identifiers"`
+ }
Review Comment:
I see. I think its a relatively new feature. Let me try it out. Also, I have
been searching for default page size on iceberg and pyiceberg as reference but
have not found any. Is it okay to use an arbitrary number of 20?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
