zeroshade commented on code in PR #290:
URL: https://github.com/apache/iceberg-go/pull/290#discussion_r1949662180
##########
catalog/rest/rest.go:
##########
@@ -989,3 +989,54 @@ func (r *Catalog) CheckTableExists(ctx context.Context,
identifier table.Identif
}
return true, nil
}
+
+func (r *Catalog) ListViews(ctx context.Context, namespace table.Identifier)
([]table.Identifier, error) {
+ if err := checkValidNamespace(namespace); err != nil {
+ return nil, err
+ }
+
+ ns := strings.Join(namespace, namespaceSeparator)
+ path := []string{"namespaces", ns, "views"}
+
+ type resp struct {
+ Identifiers []identifier `json:"identifiers"`
+ }
Review Comment:
Looks like you're missing the `next-page-token` here:
https://github.com/apache/iceberg/blob/3e6da2e5437ffb3f643275927e5580cb9620256b/open-api/rest-catalog-open-api.yaml#L3882
Probably means we'd also need to implement handling the next-page-token and
page-size parameters for use with `doGet` repeatedly to ensure we get ALL the
views (or otherwise change this API to enable paging by the caller)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
