gaborkaszab commented on code in PR #12089:
URL: https://github.com/apache/iceberg/pull/12089#discussion_r1952698753
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -72,6 +72,26 @@ public static TestTable create(
return new TestTable(ops, name);
}
+ public static TestTable create(
Review Comment:
Indeed. Done.
Anyway, I was thinking of introducing a Builder for these test tables. I see
that we have a number of variations now (with-without MetricsReporter,
TableOperations and now in the partition stats PR we'll have one for props too)
and might be cleaner to have a builder instead of these different create()
methods. WDYT @nastra ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
