nastra commented on code in PR #12089:
URL: https://github.com/apache/iceberg/pull/12089#discussion_r1952668061
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -72,6 +72,26 @@ public static TestTable create(
return new TestTable(ops, name);
}
+ public static TestTable create(
Review Comment:
you might want to change the other `create` method to call this method and
pass `ops` so that we don't duplicate the same implementations:
```
public static TestTable create(
File temp,
String name,
Schema schema,
PartitionSpec spec,
SortOrder sortOrder,
int formatVersion) {
TestTableOperations ops = new TestTableOperations(name, temp);
return create(temp, name, schema, spec, sortOrder, formatVersion, ops);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
