amitgilad3 commented on code in PR #1615: URL: https://github.com/apache/iceberg-python/pull/1615#discussion_r1947963484
########## pyiceberg/table/inspect.py: ########## @@ -384,6 +384,41 @@ def _get_all_manifests_schema(self) -> "pa.Schema": all_manifests_schema = all_manifests_schema.append(pa.field("reference_snapshot_id", pa.int64(), nullable=False)) return all_manifests_schema + def _get_positional_file_schema(self) -> "pa.Schema": + import pyarrow as pa + + from pyiceberg.io.pyarrow import schema_to_pyarrow + + pa_row_struct = schema_to_pyarrow(self.tbl.schema().as_struct()) + positinal_delete_schema = pa.schema( + [ + pa.field("file_path", pa.string(), nullable=False), + pa.field("pos", pa.int64(), nullable=False), + pa.field("row", pa_row_struct, nullable=True), + ] + ) + return positinal_delete_schema + + def _get_positional_deletes_schema(self) -> "pa.Schema": + import pyarrow as pa + + from pyiceberg.io.pyarrow import schema_to_pyarrow + + partition_record = self.tbl.metadata.specs_struct() Review Comment: good catch , i now take the current PartitionSpec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org