amitgilad3 commented on code in PR #1615:
URL: https://github.com/apache/iceberg-python/pull/1615#discussion_r1960514947
##########
pyiceberg/io/pyarrow.py:
##########
@@ -889,6 +890,19 @@ def _construct_fragment(fs: FileSystem, data_file:
DataFile, file_format_kwargs:
return _get_file_format(data_file.file_format,
**file_format_kwargs).make_fragment(path, fs)
+def _read_delete_file(fs: FileSystem, data_file: DataFile) ->
Iterator[PositionDelete]:
Review Comment:
Just to make sure i did it right , i converted _read_deletes to use
_read_delete_file so we don't implement the reading part twice , and kept the
logic of _read_deletes to return Dict[str, pa.ChunkedArray]
wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
