dramaticlly commented on code in PR #12006:
URL: https://github.com/apache/iceberg/pull/12006#discussion_r1945554585


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -940,16 +1024,20 @@ protected void checkFileNum(
             .load(result.fileListLocation())
             .as(Encoders.STRING())
             .collectAsList();
-    assertThat(filesToMove.stream().filter(f -> 
f.endsWith(".metadata.json")).count())
-        .withFailMessage("Wrong rebuilt version file count")
+    Predicate<String> isManifest = f -> (f.endsWith("-m0.avro") || 
f.endsWith("-m1.avro"));

Review Comment:
   yeah looks like I can remove more brackets and this works
   ```java
       Predicate<String> isManifest = f -> f.endsWith("-m0.avro") || 
f.endsWith("-m1.avro");
       Predicate<String> isManifestList = f -> f.contains("snap-") && 
f.endsWith(".avro");
       Predicate<String> isMetadataJSON = f -> f.endsWith(".metadata.json");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to