flyrain commented on PR #12006: URL: https://github.com/apache/iceberg/pull/12006#issuecomment-2613545458
> > Yes, thanks for fixing the issue (found by our internal usage). > > I wonder, because the deleted entry may be important for CDC (to mark that this file at some point existed), is another possibility to skip the deleted file for copy? cc @flyrain for thoughts as well > > Sounds good, I updated the PR to keep the deleted entry but exclude deleted content files from copy plan CDC is fine as it won't work anyway if the data file has been removed. +1 to keep the entry in the manifest file as this tool isn't supposed to change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
